Skip to content

Create wrapper shim scripts#768

Merged
adwsingh merged 3 commits into
mainfrom
adwsingh/shims
Jun 11, 2025
Merged

Create wrapper shim scripts#768
adwsingh merged 3 commits into
mainfrom
adwsingh/shims

Conversation

@adwsingh

Copy link
Copy Markdown
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Comment on lines +405 to +406
boolean alreadyPresent = lines.stream()
.anyMatch(line -> line.contains(shimsDirStr) && line.contains("PATH"));

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This returns true even if the line is commented out

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I check now if the line starts with #.

@adwsingh
adwsingh requested a review from rhernandez35 June 11, 2025 20:41
@adwsingh
adwsingh merged commit c1c86c3 into main Jun 11, 2025
2 checks passed
@adwsingh
adwsingh deleted the adwsingh/shims branch June 11, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants